Bug #167827 fix: Showing incomplete vendor profile #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 1 new issues, 1 updated code elements |
snehal0904
reviewed
Jan 20, 2021
| @@ -660,7 +661,15 @@ public function getVendorProfileStatus($userId, $client) | |||
| $total += (!empty($data->vat_number)) ? 5: 0; | |||
| $total += (!empty($data->vendor_description)) ? 5: 0; | |||
| $total += (!empty($data->vendor_logo))? 5: 0; | |||
| $total += (!empty($data->payment_gateway)) ? 5: 0; | |||
|
|
|||
| if ($sendPaymentsToOwner == '0') | |||
There was a problem hiding this comment.
@deepgawade89 you want to check 2 things here. First - send payment directly to the vendor is enabled or not.
OR
Second - Adaptive/split payment gateway is getting used by the client (JT/JGive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "Send payments directly to campaign promoter without charging any commissions (works only with Paypal payment gateway)" as Yes in that case profile should display 100% if vendor has filled remaining all details.
If "Send payments directly to campaign promoter without charging any commissions (works only with Paypal payment gateway)" as No, in that case payment gateway details should be considered to complete vendor profile.