Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-3207: Replace section specific permissions with generic ones that cover all section types #2761

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

stephenhand
Copy link
Collaborator

Description

  • Replaced all the add / edit permissions for specific case sections with addCaseSection and editCaseSection
  • Refactored ViewCaseItem to use redux hooks rather than mappings

Checklist

  • Corresponding issue has been opened
  • New tests added
  • [n/a] Feature flags added
  • [n/a] Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand changed the title CHI-207: Replace section specific permissions with generic ones that cover all section types CHI-3207: Replace section specific permissions with generic ones that cover all section types Feb 5, 2025
Copy link
Collaborator

@GPaoloni GPaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I assume there's an HRM PR this one depends on (hrm needs to be in place before this is deployed I think)?

@stephenhand
Copy link
Collaborator Author

LGTM!

I assume there's an HRM PR this one depends on (hrm needs to be in place before this is deployed I think)?

Yes, this version will be dependent on the new HRM version being deployed (but not vice versa) - I think you already approved that PR

@stephenhand stephenhand merged commit 380e382 into master Feb 6, 2025
16 checks passed
@stephenhand stephenhand deleted the CHI-3207-case_section_permission branch February 6, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants