Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set SiteNoteNode to be not null #945

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: Set SiteNoteNode to be not null #945

merged 1 commit into from
Oct 31, 2023

Conversation

david-code
Copy link
Contributor

Description

Needs a Terraso Connection for django-graphene to pick up on the fact that there are no null objects in the connection.

@david-code david-code requested a review from ajabeckett October 31, 2023 21:20
ajabeckett
ajabeckett approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ajabeckett ajabeckett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@david-code
Copy link
Contributor Author

@ajabeckett I'll let you merge, I'm not sure if you are just using the hash from this commit directly and I don't want to interrupt you.

@ajabeckett ajabeckett merged commit c8bfcd9 into main Oct 31, 2023
6 checks passed
@ajabeckett ajabeckett deleted the fix/set-site-note-node-not-null branch October 31, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajabeckett ajabeckett ajabeckett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-code @ajabeckett