Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caused by #870
When memberships are deleted, they are still included in the Django automatic joins between projects, membership lists and memberships. For example, here is the SQL generated by trying to select for related memberships from a project (made some manual edits for clarity when debugging):
You can see only projects are being checked if
deleted_at IS NULL
, when memberships and membership lists should be checked as well.The easiest fix for now is just to add this check explicitly, like I've done. Eventually we need to figure out why this is not behaving as I expect.