Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError with BigInt param #1677

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

paulish
Copy link
Contributor

@paulish paulish commented Jul 2, 2024

What this does:

PR fixes a TypeError "Cannot mix BigInt and other types, use explicit conversions" when passing a bigint parameter to request

The following example crashed with error:

const request = new mssql.Request();
request.input('bigintpara', BigInt('4294967294'));

Now it does not raise an error.

Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks.

I think we should add a unit test to cover this

@dhensby dhensby merged commit 8931bcf into tediousjs:master Jul 2, 2024
45 checks passed
@paulish
Copy link
Contributor Author

paulish commented Jul 3, 2024

@dhensby tedious also has related bigint problem (seems bigint is not a popular js type) tediousjs/tedious#1642

Copy link

github-actions bot commented Jul 3, 2024

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants