-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task #229025 - [FE] - Authentication pages UI #1
base: main
Are you sure you want to change the base?
Conversation
"preview": "vite preview" | ||
}, | ||
"dependencies": { | ||
"@chakra-ui/icons": "^2.2.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using two icon libraries: react-icons and @chakra-ui/icons?
@@ -0,0 +1,69 @@ | |||
.purple-bg{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this CSS file? Please remove it and use it as a component prop instead.
@@ -0,0 +1,69 @@ | |||
.purple-bg{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same App.css file is included twice; please check. Also, please remove the empty CSS files, index.css and style.css.
onOpen(); | ||
}; | ||
return ( | ||
<Box className="main-bg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a common layout component.
Don't use className or CSS classes here; use components and props instead.
</Box> | ||
|
||
<Box m={4}> | ||
<Button className="custom-btn" type="submit" mt={4} width="100%" onClick={openModal}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the button from the common component.
<FormControl> | ||
<FormLabel color={"#45464F"}> | ||
Select Preferred Language | ||
</FormLabel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the common component, and the label should be changed using props.
<Box className="main-bg"> | ||
<Flex height="100vh" alignItems="center" justifyContent="center" position="relative"> | ||
<Box | ||
width="550px" | ||
height="100vh" | ||
borderRadius="lg" | ||
shadow="lg" | ||
borderWidth="1px" | ||
background="#fff" | ||
className="layout" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout common component missing
}; | ||
|
||
return ( | ||
<Box className="main-bg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout common component missing
|
||
<ModalCloseButton /> | ||
<ModalBody className="border-bottom"> | ||
<Heading as="h5" size="md" mt="1" mb="2" color="gray.800" fontWeight="400" lineHeight={'30px'}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure the exact colors specified in Figma are used instead of gray.800
No description provided.