Use class Peekable for parser
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuroevolutus
had a problem deploying
to
scrapscript-pr-228
GitHub Actions
Failure
tekknolagi
had a problem deploying
to
scrapscript-pr-228
GitHub Actions
Failure
tekknolagi
reviewed
Jan 20, 2025
scrapscript.py
Outdated
| return String(token.value) | ||
| elif token == Operator("..."): | ||
| try: | ||
| if isinstance(tokens.peek(), Name): |
There was a problem hiding this comment.
This kind of stuff is really subtle and I am wondering if there is a way we can clean it up somehow. Maybe some kind of have_tokens() function? :/
tekknolagi
had a problem deploying
to
scrapscript-pr-228
GitHub Actions
Failure
|
Great stuff! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
class Peekablewhich augments an argumentIteratorwith apeekmethod. The parser now takes as input an instance ofclass Peekablethat produces a series of tokens rather than relying on a materialisedlistof tokens. For right now,tokenizeis altered to wrap the returnedlistof tokens in an instance ofclass Peekable, but, with another PR, we should be able to complete issue #84 and make the lexer fully pull-driven by turning it into a properIterator, which we would wrap within an instance ofclass Peekable.