forked from facebookarchive/skybison
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up bootstrap __build_class__ a little bit #426
Open
tekknolagi
wants to merge
1
commit into
trunk
Choose a base branch
from
mb-speed-up-build-class
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
force-pushed
the
mb-speed-up-build-class
branch
from
March 23, 2023 20:29
a7b3533
to
d727b03
Compare
Summary
Base vs. New
CPython vs New
Base
New
CPython
|
Since we're iterating over the layouts table one by one, and the layouts table will always be at least LayoutId::kLastBuiltinId layouts long, use `Tuple::at` instead of `Runtime::layoutAtSafe`, which does a bunch of checks. This search is still linear and kind of long, though.
tekknolagi
force-pushed
the
mb-speed-up-build-class
branch
from
March 23, 2023 21:10
d727b03
to
1374a10
Compare
Summary
Base vs. New
CPython vs New
Base
New
CPython
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're iterating over the layouts table one by one, and the layouts table will always be at least LayoutId::kLastBuiltinId layouts long, use
Runtime::layoutAt
instead ofRuntime::layoutAtSafe
, which does a bunch of checks. This search is still linear and kind of long, though.