Track when the asm interpreter transitions into C++ interpreter #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
force-pushed
the
mb-interpreter-deopt
branch
from
cd7f8fd
to
3a6e8d6
Compare
|
|
tekknolagi
force-pushed
the
mb-interpreter-deopt
branch
from
3a6e8d6
to
1c08d58
Compare
|
|
|
|
|
And |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
In debug(opt) mode, register a bpftrace event that fires when the assembly interpreter switches to the C++ interpreter. This also includes opcodes that have no assembly implementation (and therefore always switch to C++).
For richards.py this occurs 25330 times, according to the bpftrace script. It is not the hottest, but it is easy to implement. (smaller) ... @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_COMPARE_IN_MONOMORPHIC]: 14073 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_COMPARE_EQ_STR]: 17581 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_LOAD_ATTR_INSTANCE_TYPE]: 19845 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_LOAD_ATTR_INSTANCE_SLOT_DESCR]: 25330 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_BUILD_TUPLE]: 27540 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_GET_ITER]: 44881 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_INPLACE_OP_MONOMORPHIC]: 56030 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_BINARY_FLOORDIV_SMALLINT]: 57701 @interpreter_deopt[usdt:./build/bin/python:python:InterpreterDeopt_BINARY_OP_MONOMORPHIC]: 58618 (higher)
This brings it down from 19727 to 4101 transitions from asm to C++.
tekknolagi
force-pushed
the
mb-interpreter-deopt
branch
from
1c08d58
to
4b916d3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can measure which opcodes do this most frequently with bpftrace. This lets us see, for example, that we should probably implement a handler for
LOAD_ATTR_INSTANCE_SLOT_DESCR(included in this PR).