feat: hackernews #206
Merged
feat: hackernews #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aldy505
commented
Nov 12, 2023
aldy505
commented
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 26 26
Lines 1619 1619
=======================================
Hits 1278 1278
Misses 341 341 ☔ View full report in Codecov by Sentry. |
krowter
reviewed
Nov 12, 2023
elianiva
requested changes
Nov 13, 2023
Co-authored-by: Dicha Zelianivan Arkana <[email protected]>
elianiva
requested changes
Nov 13, 2023
src/services/hackernews/index.js
Outdated
Comment on lines
46
to
54
| const item = await getItem(story); | ||
| // We only want stories. Not job, comment, or poll | ||
| if (item?.type !== "story") continue; | ||
| // We only want stories that's high in rating | ||
| if (item?.score < 100) continue; | ||
| // It's useless if it's dead. | ||
| if (item?.dead) continue; | ||
| // We don't want old stories to come up. Limit this to last 24 hours. | ||
| if (item?.time && (item.time * 1000) < last24Hours.getTime()) continue; |
There was a problem hiding this comment.
kalo item null / undefined langsung continue aja, biar ngga kebanyakan optional chaining
There was a problem hiding this comment.
field nya yang mungkin null. item nggak mungkin null.
There was a problem hiding this comment.
tapi item?.type implies item itu bisa null atau undefined
kalo emang item ga bisa null, mestinya ga perlu optional chaining
krowter
approved these changes
Nov 13, 2023
elianiva
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.