Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eval): use gold for acquiring stock data #215

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Jan 7, 2024

No description provided.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (dd91d9f) 79.14% compared to head (034e612) 81.46%.

Files Patch % Lines
src/services/eval/stock.js 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   79.14%   81.46%   +2.31%     
==========================================
  Files          26       26              
  Lines        1645     1597      -48     
==========================================
- Hits         1302     1301       -1     
+ Misses        343      296      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +24 to +32
const response = {
name: body.symbol,
close: body.close,
previous: body.open,
high: body.high,
low: body.low,
volume: body.volume,
value: body.close
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biar apa wkwkwk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gainget

@elianiva elianiva merged commit 5137125 into master Jan 8, 2024
4 of 5 checks passed
@elianiva elianiva deleted the feat/eval-stock-use-gold branch January 8, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants