fix(rce): security fix regarding open PATH environment #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 82.02% 82.02%
=======================================
Files 34 34
Lines 1463 1463
Branches 90 90
=======================================
Hits 1200 1200
Misses 231 231
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elianiva
approved these changes
Jun 1, 2023
brought changes from #117
|
still don't understand why the build rce pipeline returns a non zero exit code. might revisit this later. |
RayWP
approved these changes
Jun 9, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Everything is green. Hoping to cause minimum damage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a conversation between me and @ii64
Reinaldy, [01/06/2023 11:35]
@lolioverflow btw i need to borrow your brain. kalo gw punya ruby or any executables di /opt/ruby/3.2/bin/ruby, dan gw set $PATH ke /opt/ruby/3.2/bin doang, tanpa set additional kayak PATH=/opt/ruby/3.2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, gw udah coba sih ruby nya bisa gw exec. tapi bakal ada problem soal integrate ke some C libraries ga sih?
Reinaldy, [01/06/2023 11:36]
atau gw harus set LD_LIBRARY_PATH, CC dan CXX sendiri?
Maple Syrup, [01/06/2023 11:37]
Seharusnya masih bisa, ld lookup nya tetep managed by OS
Reinaldy, [01/06/2023 11:38]
hooo okay, artinya LD lookup ga depends on what's on PATH kan? tapi harusnya depends on env LD_* if any?
Maple Syrup, [01/06/2023 11:38]
Yep, higher precedence
Reinaldy, [01/06/2023 11:38]
ok nice