Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rce): instrument tracing #135

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Aug 26, 2023

  • Instrument Sentry tracing manually
  • Update a few dependencies

@aldy505 aldy505 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 26, 2023
@aldy505 aldy505 requested a review from elianiva as a code owner August 26, 2023 14:01
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: +0.50% 🎉

Comparison is base (44dbdff) 82.04% compared to head (81481e3) 82.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   82.04%   82.55%   +0.50%     
==========================================
  Files          34       34              
  Lines        1476     1519      +43     
  Branches       90      104      +14     
==========================================
+ Hits         1211     1254      +43     
+ Misses        234      221      -13     
- Partials       31       44      +13     
Flag Coverage Δ
auth 42.10% <ø> (+5.26%) ⬆️
rce 90.66% <81.25%> (-1.92%) ⬇️
sdk-dotnet 96.56% <ø> (ø)
sdk-go 66.48% <ø> (ø)
sdk-javascript 88.69% <ø> (ø)
sdk-python 99.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
rce/src/user/user.ts 91.22% <66.66%> (-8.78%) ⬇️
rce/src/job/job.ts 88.62% <85.71%> (-1.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elianiva
Copy link
Member

conflict

@aldy505 aldy505 merged commit 3c1bfea into master Sep 3, 2023
25 of 26 checks passed
@aldy505 aldy505 deleted the feat/rce/instrument-tracing branch September 3, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants