-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove memory_limit for tengo #163
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 81.17% 81.17%
=======================================
Files 34 34
Lines 1535 1535
Branches 140 140
=======================================
Hits 1246 1246
Misses 223 223
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8dab466
to
3fbc5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh btw this causes an error on CI. See
file:///app/dist/index.js:17861
throw new TypeError("Invalid runtime parameters: memoryLimit is 0 or less");
^
TypeError: Invalid runtime parameters: memoryLimit is 0 or less
at new Runtime (file:///app/dist/index.js:17861:13)
at acquireRuntime (file:///app/dist/index.js:17[93](https://github.com/teknologi-umum/pesto/actions/runs/7781391843/job/21219273603?pr=163#step:2:98)7:23)
at async file:///app/dist/index.js:18002:30
You should set should_limit_memory
to false
and put some value on the memory_limit
Noted that |
No description provided.