Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Manifest annotations in bundle push #2105

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Support for Manifest annotations in bundle push #2105

merged 1 commit into from
Aug 28, 2023

Conversation

zregvart
Copy link
Contributor

@zregvart zregvart commented Aug 24, 2023 •
edited
Loading

Changes

Adds --annotate parameter to tkn bundle push to set any OCI Manifest annotations on the bundle image.

Fixes #1933

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Add support for OCI Manifest Annotations via "--annotate" parameter to "tkn bundle push"

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 24, 2023
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 24, 2023
@tekton-robot
Copy link
Contributor

Hi @zregvart. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2023
piyush-garg
piyush-garg reviewed Aug 24, 2023
View reviewed changes
pkg/cmd/bundle/push.go Outdated Show resolved Hide resolved
@piyush-garg
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
vinamra28
vinamra28 reviewed Aug 25, 2023
View reviewed changes
pkg/cmd/bundle/push.go Outdated
@@ -80,6 +83,7 @@ Input:
},
}
c.Flags().StringSliceVarP(&opts.bundleContentPaths, "filenames", "f", []string{}, "List of fully-qualified file paths containing YAML or JSON defined Tekton objects to include in this bundle")
c.Flags().StringSliceVarP(&opts.annotationParams, "annotate", "a", []string{}, "OCI Manifest annotations in the form of key=value to be added to the OCI image")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-a flag sounds bit odd 😅 , let's keep --annotate only and not add any short-hand of this flag.
@piyush-garg @chmouel @vdemeester please let me know your thoughts on it

vinamra28
vinamra28 reviewed Aug 25, 2023
View reviewed changes
pkg/cmd/bundle/push.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2023
@piyush-garg
Copy link
Contributor

lgtm
cc @vinamra28

@piyush-garg
Copy link
Contributor

Please update commit message and PR desc for -a flag as it is removed now

@vinamra28
Copy link
Member

Please update commit message and PR desc for -a flag as it is removed now

@zregvart can you please take a look at this and then we can merge this PR

@zregvart
Support for Manifest annotations in bundle push
ead9aa2 
Adds `--annotate` parameter to `tkn bundle push` to set any OCI Manifest
annotations on the bundle image.

Fixes tektoncd#1933
@vinamra28
Copy link
Member

/test pull-tekton-cli-integration-tests

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@tekton-robot tekton-robot merged commit 7e7daaf into tektoncd:main Aug 28, 2023
2 checks passed
@zregvart
Copy link
Contributor Author

Thanks!

@zregvart zregvart deleted the issue/1933 branch August 28, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@piyush-garg piyush-garg piyush-garg left review comments

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel Awaiting requested review from chmouel

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for annotating image manifest for OCI bundles
5 participants
@zregvart @tekton-robot @piyush-garg @vinamra28 @vdemeester