Skip to content

Commit

Permalink
Remove todo items related to changes in use of className prop
Browse files Browse the repository at this point in the history
In Carbon v11 a number of components have changed their use of the
className prop. To improve consistency it is now applied to the
outermost element rendered by the component.

Verified that we don't currently use the className prop on any of
the TooltipDropdown instances, and existing use of the className prop
on our tables still works with the new changes.
  • Loading branch information
AlanGreene committed Jul 12, 2024
1 parent 3745f6a commit 10a47dd
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const TooltipDropdown = ({

return (
<ComboBox
className={className} // TODO: carbon11 - Step 6 - className now applies to the outermost element
className={className}
disabled={disabled}
id={id}
inline={inline}
Expand Down
2 changes: 0 additions & 2 deletions src/containers/ClusterTasks/ClusterTasks.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ function ClusterTasksContainer() {
}
];

// TODO: carbon11 - Step 6 - className now applies to the outermost element of Table

return (
<ListPageLayout
error={getError()}
Expand Down
2 changes: 0 additions & 2 deletions src/containers/Pipelines/Pipelines.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@ export function Pipelines() {
}
];

// TODO: carbon11 - Step 6 - className now applies to the outermost element of Table

return (
<ListPageLayout
error={getError()}
Expand Down
2 changes: 0 additions & 2 deletions src/containers/Tasks/Tasks.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,6 @@ function Tasks() {
}
];

// TODO: carbon11 - Step 6 - className now applies to the outermost element of Table

return (
<ListPageLayout
error={getError()}
Expand Down
3 changes: 1 addition & 2 deletions src/containers/YAMLEditor/YAMLEditor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@ export default function YAMLEditor({
lowContrast
/>
)}
{/* TODO: carbon11 - Step 6 - className now applies to the outermost element of FormGroup */}
<FormGroup legendText="" className="tkn--codemirror--form">
<FormGroup legendText="">
{loading ? (
<Loading message={loadingMessage} />
) : (
Expand Down

0 comments on commit 10a47dd

Please sign in to comment.