Skip to content

Commit

Permalink
Improve ServiceAccount labels to inform users of default SA behaviour…
Browse files Browse the repository at this point in the history
… and need for RBAC
  • Loading branch information
a-roberts authored and tekton-robot committed Jun 10, 2020
1 parent ca2e27c commit c5e6a8d
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/containers/CreatePipelineRun/CreatePipelineRun.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,11 @@ class CreatePipelineRun extends React.Component {
id: 'dashboard.serviceAccountLabel.optional',
defaultMessage: 'ServiceAccount (optional)'
})}
helperText={intl.formatMessage({
id: 'dashboard.createPipelineRun.serviceAccountHelperText',
defaultMessage:
'Ensure the selected ServiceAccount (or the default if none selected) has permissions for creating PipelineRuns and for anything else your PipelineRun interacts with.'
})}
namespace={namespace}
selectedItem={
serviceAccount
Expand Down
5 changes: 5 additions & 0 deletions src/containers/CreateTaskRun/CreateTaskRun.js
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,11 @@ class CreateTaskRun extends React.Component {
id: 'dashboard.serviceAccountLabel.optional',
defaultMessage: 'ServiceAccount (optional)'
})}
helperText={intl.formatMessage({
id: 'dashboard.createTaskRun.serviceAccountHelperText',
defaultMessage:
'Ensure the selected ServiceAccount (or the default if none selected) has permissions for creating TaskRuns and for anything else your TaskRun interacts with.'
})}
namespace={namespace}
selectedItem={
serviceAccount
Expand Down
2 changes: 1 addition & 1 deletion src/containers/ImportResources/ImportResources.js
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ export class ImportResources extends Component {
helperText={intl.formatMessage({
id: 'dashboard.importResources.serviceAccount.helperText',
defaultMessage:
'The ServiceAccount that the PipelineRun will run under (from the namespace above)'
'The ServiceAccount that the PipelineRun applying resources will run under (from the namespace above). Ensure the selected ServiceAccount (or the default if none selected) has permissions for creating PipelineRuns and for anything else your PipelineRun interacts with, including any Tekton resources in the Git repository.'
})}
id="import-service-accounts-dropdown"
namespace={this.state.importerNamespace}
Expand Down
9 changes: 9 additions & 0 deletions src/containers/ImportResources/ImportResources.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ limitations under the License.
}

.tkn--importresources-outer {

.bx--form__helper-text {
color: $text-05; // Since by default the contrast/colour choice is barely readable.
}

.bx--label--disabled {
color: $text-05;
}

background-color: white;
min-height: 30rem;

Expand Down
9 changes: 9 additions & 0 deletions src/scss/CreateRun.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ limitations under the License.
margin-bottom: 0;
}

.bx--form__helper-text {
color: $text-05; // Since by default the contrast/colour choice is barely readable.
max-width: 100%;
}

.bx--label--disabled {
color: $text-05;
}

.bx--text-input__field-wrapper {
width: 100%;
}
Expand Down

0 comments on commit c5e6a8d

Please sign in to comment.