Update display of retries #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/feature
|
Failed downloading Node.js, unrelated to these changes |
Update the way pipeline task retries are displayed in the Dashboard. Instead of displaying each attempt as if it were an independent TaskRun, display them as a single TaskRun as is actually the case on the cluster. This means that users now need a new way to access logs / status etc. of previous retry attempts. Add an overflow menu on an expanded task which has retries, allowing the user to select the desired retry to view. Keep the existing behaviour that selecting the latest attempt of an in-progress task will update to show the latest status of subsequent attempts. The net result of this change is that the UI is a lot cleaner when retries are in play, a successful PipelineRun won't show any red / error state by default, but will still clearly communicate to the user that retries took place so they can investigate further if needed. This change also add support for displaying retry status on the TaskRun details page which previously only showed the status of the latest attempt.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses the retries part of #1445
Update the way pipeline task retries are displayed in the Dashboard. Instead of displaying each attempt as if it were an independent TaskRun, display them as a single TaskRun as is actually the case on the cluster.
This means that users now need a new way to access logs / status etc. of previous retry attempts. Add an overflow menu on an expanded task which has retries, allowing the user to select the desired retry to view.
Keep the existing behaviour that selecting the latest attempt of an in-progress task will update to show the latest status of subsequent attempts.
The net result of this change is that the UI is a lot cleaner when retries are in play, a successful PipelineRun won't show any red / error state by default, but will still clearly communicate to the user that retries took place so they can investigate further if needed.
This change also add support for displaying retry status on the TaskRun details page which previously only showed the status of the latest attempt.
/kind feature
Before:
After:
Menu to view retry details:
Viewing a retry:
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes