Add support for log groups #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/feature
AlanGreene
force-pushed
the
log_groups
branch
3 times, most recently
from
99216e5 to
1608b3c
Compare
AlanGreene
force-pushed
the
log_groups
branch
from
1608b3c to
f9e12fa
Compare
Update log viewer to support `::group::` and `::endgroup::` commands which create collapsible groups in the log content. When logs of a running step are viewed, groups are rendered in their expanded state by default. When logs of a completed step are viewed, groups are rendered in their collapsed state by default. In either case, if a user manually toggles a group, that state is respected until they switch to another view, regardless of the running state of the step.
AlanGreene
force-pushed
the
log_groups
branch
from
f9e12fa to
16d5c6c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #3768
Related to #2306
Update log viewer to support
::group::and::endgroup::commands which create collapsible groups in the log content.When logs of a running step are viewed, groups are rendered in their expanded state by default. When logs of a completed step are viewed, groups are rendered in their collapsed state by default.
In either case, if a user manually toggles a group, that state is respected until they switch to another view, regardless of the running state of the step.
/kind feature
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes