Support Triggers 0.2 features in the Dashboard #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
size/XL
tekton-robot
added
size/XXL
tekton-robot
removed
the
do-not-merge/work-in-progress
AlanGreene
reviewed
Feb 5, 2020
AlanGreene
reviewed
Feb 5, 2020
ncskier
force-pushed
the
issue944
branch
4 times, most recently
from
b50693a to
21ebb0e
Compare
|
Thanks for the review @AlanGreene! I've addressed all of your change requests, so please take another look over the PR when you get the chance 🙂 |
AlanGreene
requested changes
Feb 7, 2020
|
@AlanGreene thanks for the review! I just updated the code to address all of your requests; let me know what you think! 👍 |
Fixes tektoncd#944 Updates the EventListener details page with the following: - Multiple Interceptors - Multiple TriggerBindings - No more params - Display all 4 built-in types of Interceptors (Webhook, GitHub, GitLab, and CEL)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #944
Updates the EventListener details page with the following:
and CEL)
Here is a screenshot of the updated EventListener component:
/cc @AlanGreene
/cc @a-roberts
I still need to update/add tests and probably clean up the code a little bit. However, any initial feedback would be very helpful 🙂
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.