Remove cluster task installersets #2376

pratap0007 · 2024-10-16T05:48:22Z

Changes

This patch will remove cluster task installersets and also
remove the existing cluster task installersets during operator upgrade

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Run make test lint before submitting a PR
Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Cluster Task has been deprecated, hence this PR disable the create of cluster task installersets and will remove all existing cluster task installersets from the cluster.

tekton-robot · 2024-10-16T05:48:25Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tekton-robot · 2024-10-16T05:48:44Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2024-10-18T13:17:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-10-18T14:00:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-10-21T03:16:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-10-21T04:20:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

vdemeester · 2024-11-05T10:07:31Z

cc @jkandasa

tekton-robot · 2024-11-07T10:43:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-11-07T12:50:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-11-07T23:47:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go	39.1%	100.0%	60.9
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	47.9%	5.3

tekton-robot · 2024-11-11T13:18:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

tekton-robot · 2024-11-12T03:50:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

pratap0007 · 2024-11-12T05:40:09Z

/retest

tekton-robot · 2024-11-13T09:38:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

tekton-robot · 2024-11-14T05:13:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

savitaashture · 2024-11-14T12:33:49Z

@pratap0007 You need to change these templates https://github.com/tektoncd/operator/blob/main/cmd/openshift/operator/kodata/tekton-addon/tekton-pipeline-template/pipeline_using_workspace.yaml#L25-L26 to use the resolverTasks now instead of ClusterTask

Use below sample format instead of clusterTask

    tasks:
    - name: kn-run
      taskRef:
        resolver: cluster
        params:
        - name: kind
          value: task
        - name: name
          value: kn
        - name: namespace
          value: openshift-pipelines

tekton-robot · 2024-11-18T06:08:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	89.5%	2.0
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

pkg/reconciler/shared/tektonconfig/upgrade/post_upgrade.go

pkg/apis/operator/v1alpha1/const.go

pkg/reconciler/openshift/tektonaddon/transformer.go

pkg/reconciler/shared/tektonconfig/upgrade/post_upgrade.go

ppitonak · 2024-11-18T15:31:27Z

Makefile

@@ -67,7 +67,7 @@ ifeq ($(TARGET), openshift)
 	rm -rf ./cmd/$(TARGET)/operator/kodata/manual-approval-gate
 	rm -rf ./cmd/$(TARGET)/operator/kodata/tekton-pruner
 	rm -rf ./cmd/$(TARGET)/operator/kodata/tekton-addon/pipelines-as-code
-	rm -rf ./cmd/$(TARGET)/operator/kodata/tekton-addon/addons/02-clustertasks/source_external/
+	rm -rf ./cmd/$(TARGET)/operator/kodata/tekton-addon/addons/02-tasks/source_external/


This is probably related to the question that Savita asked in hack/fetch-releases.sh. I don't understand what this is supposed to contain.

this contains fetched tasks from the catalogs and we should remove this, right @savitaashture ?

pkg/apis/operator/v1alpha1/tektonaddon_validation_test.go

ppitonak · 2024-11-18T15:49:23Z

pkg/reconciler/shared/tektonconfig/upgrade/upgrade.go

@@ -38,7 +38,8 @@ var (

 	// post upgrade functions
 	postUpgradeFunctions = []upgradeFunc{
-		upgradeStorageVersion, // upgrade #1: performs storage version migration
+		upgradeStorageVersion,              // upgrade #1: performs storage version migration
+		removeAllClusterTasksInstallerSets, // Remove all cluster tasks installersets


Do I understand it correctly that after upgrading from 1.16 to 1.17, all clustertasks (even old versioned ones for 1.14 or 1.15) will be removed automatically?

yes, all cluster tasks will be removed automatically

This patch will remove cluster task installersets and also remove the existing cluster task installersets during operator upgrade Signed-off-by: Shiv Verma <[email protected]>

tekton-robot · 2024-11-18T17:29:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go	87.5%	90.9%	3.4
pkg/reconciler/openshift/tektonaddon/transformer.go	42.6%	56.1%	13.5

pratap0007 · 2024-11-18T17:53:27Z

Thanks @savitaashture @PuneetPunamiya @ppitonak @jkhelil for review and I have updated, please take a final review

pratap0007 · 2024-11-18T18:44:43Z

/retest

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2024

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024

tekton-robot requested review from jkhelil and PuneetPunamiya October 16, 2024 05:48

pratap0007 force-pushed the remove-ct-installersets branch from 32727c8 to 70d230c Compare October 18, 2024 13:08

pratap0007 changed the title ~~[WIP]Remove cluster task installersets~~ Remove creation of cluster task installersets Oct 18, 2024

pratap0007 marked this pull request as ready for review October 18, 2024 13:11

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024

tekton-robot requested a review from piyush-garg October 18, 2024 13:11

pratap0007 force-pushed the remove-ct-installersets branch from 70d230c to dc05781 Compare October 18, 2024 13:53

pratap0007 force-pushed the remove-ct-installersets branch from dc05781 to 0a7bc2f Compare October 21, 2024 03:06

pratap0007 force-pushed the remove-ct-installersets branch from 0a7bc2f to f743fbf Compare October 21, 2024 04:11

pratap0007 changed the title ~~Remove creation of cluster task installersets~~ [WIP] Remove creation of cluster task installersets Nov 5, 2024

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024

pratap0007 force-pushed the remove-ct-installersets branch from f743fbf to 338f7a2 Compare November 7, 2024 10:30

pratap0007 changed the title ~~[WIP] Remove creation of cluster task installersets~~ Remove cluster task installersets Nov 7, 2024

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024

pratap0007 force-pushed the remove-ct-installersets branch from 338f7a2 to c4c7993 Compare November 7, 2024 12:43

pratap0007 force-pushed the remove-ct-installersets branch from c4c7993 to 8234c1b Compare November 7, 2024 23:39

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2024

pratap0007 force-pushed the remove-ct-installersets branch from c97c6bb to 3dd935d Compare November 12, 2024 03:45

pratap0007 force-pushed the remove-ct-installersets branch from 3dd935d to df7b7dd Compare November 13, 2024 09:31

pratap0007 force-pushed the remove-ct-installersets branch from df7b7dd to c8f03a1 Compare November 14, 2024 05:06

pratap0007 force-pushed the remove-ct-installersets branch 2 times, most recently from cfbb4ab to 6721d25 Compare November 18, 2024 06:03

jkhelil reviewed Nov 18, 2024

View reviewed changes

pkg/reconciler/shared/tektonconfig/upgrade/post_upgrade.go Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Nov 18, 2024

View reviewed changes

pkg/apis/operator/v1alpha1/const.go Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Nov 18, 2024

View reviewed changes

pkg/apis/operator/v1alpha1/const.go Show resolved Hide resolved

PuneetPunamiya reviewed Nov 18, 2024

View reviewed changes

pkg/reconciler/openshift/tektonaddon/transformer.go Show resolved Hide resolved