Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Restful API document #2060

Closed
wants to merge 17 commits into from
Closed

Add Restful API document #2060

wants to merge 17 commits into from

Conversation

anxinyf
Copy link

@anxinyf anxinyf commented Feb 17, 2020

Changes

Add Restful API document

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The document is for describing Pipeline restful API.

anxinyf and others added 17 commits October 28, 2019 14:17
Add field "ExpirationSecondsTTL" in TaskRunSpec and PipelineRunSpec.

If the field "ExpirationSecondsTTL" is set, after the TaskRun finishes, it is eligible to be automatically deleted. When the TaskRun or PipelineRun is being deleted, its lifecycle guarantees will be honored.

If this field is unset, the TaskRun won't be automatically deleted.

If this field is set to zero, the TaskRun or PipelineRun becomes eligible to be deleted immediately after it finishes. And if taskRun is produced by PipelineRun(checked via ownerReference), this ExpirationSecondsTTL will be ignored, then tekton will check PipelineRun's ExpirationSecondsTTL to determine if PipelineRun should be deleted.
Adding taskrun_expired.go and pipelinerun_expired.go which implement
approaches to delete completed TaskRun or PipelineRun via field "ExpirationSecondsTTL".
1. Add field "ExpirationTime" in PipelineRunStatus and TaskRunStatus to display expired time.

2. Add unit tests file pipelinerun_expired_test.go and taskrun_expired_test.go
1. Add field "ExpirationTime" in PipelineRunStatus and TaskRunStatus to display expired time.

2. Add unit tests file pipelinerun_expired_test.go and taskrun_expired_test.go
modify some unit test files
update func Reconcile, Reconciler struct, pipelinerun_expired, taskrun_expired
and controller.
Conflicts:
	pkg/reconciler/taskrun/controller.go
	test/builder/task.go
	vendor/github.com/gregjones/httpcache/httpcache.go
	vendor/golang.org/x/tools/imports/zstdlib.go
Bug fix for build test.
…ktoncd-master

Conflicts:
	go.mod
	vendor/modules.txt
…into tektoncd-master

Conflicts:
	pkg/apis/pipeline/v1alpha1/zz_generated.deepcopy.go
The document is for describing Pipeline restful API.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dlorenc
You can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2020
@tekton-robot
Copy link
Collaborator

Hi @anxinyf. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 17, 2020
@anxinyf anxinyf closed this Feb 17, 2020
@anxinyf anxinyf deleted the api branch February 17, 2020 16:56
@anxinyf
Copy link
Author

anxinyf commented Feb 17, 2020

Sorry, wrong commit. :D Could delete it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants