-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Restful API document #2060
Add Restful API document #2060
Conversation
Add field "ExpirationSecondsTTL" in TaskRunSpec and PipelineRunSpec. If the field "ExpirationSecondsTTL" is set, after the TaskRun finishes, it is eligible to be automatically deleted. When the TaskRun or PipelineRun is being deleted, its lifecycle guarantees will be honored. If this field is unset, the TaskRun won't be automatically deleted. If this field is set to zero, the TaskRun or PipelineRun becomes eligible to be deleted immediately after it finishes. And if taskRun is produced by PipelineRun(checked via ownerReference), this ExpirationSecondsTTL will be ignored, then tekton will check PipelineRun's ExpirationSecondsTTL to determine if PipelineRun should be deleted.
Adding taskrun_expired.go and pipelinerun_expired.go which implement approaches to delete completed TaskRun or PipelineRun via field "ExpirationSecondsTTL".
1. Add field "ExpirationTime" in PipelineRunStatus and TaskRunStatus to display expired time. 2. Add unit tests file pipelinerun_expired_test.go and taskrun_expired_test.go
1. Add field "ExpirationTime" in PipelineRunStatus and TaskRunStatus to display expired time. 2. Add unit tests file pipelinerun_expired_test.go and taskrun_expired_test.go
…into tektoncd-master Update unit tests.
…into tektoncd-master Update unit tests.
…into tektoncd-master
modify some unit test files
Conflicts: pkg/reconciler/taskrun/controller.go test/builder/task.go vendor/github.com/gregjones/httpcache/httpcache.go vendor/golang.org/x/tools/imports/zstdlib.go
format code
…ktoncd-master Conflicts: go.mod vendor/modules.txt
…into tektoncd-master Conflicts: pkg/apis/pipeline/v1alpha1/zz_generated.deepcopy.go
The document is for describing Pipeline restful API.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @anxinyf. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sorry, wrong commit. :D Could delete it? |
Changes
Add Restful API document
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes