Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deactivation of TSP Toolkit #74

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix Deactivation of TSP Toolkit #74

merged 2 commits into from
Nov 19, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Nov 19, 2024

  • Change kicList member from readonly to private with accessor
  • Add logging
  • change fetch* methods to be get functions
  • Update progress bar to use something the isn't 50% (it didn't look like it was actually a progress bar
  • Change terminal to be transient so it isn't recreated on VSCode restart

@esarver
Fix Deactivation of TSP Toolkit
90e5486 
- Change `kicList` member from `readonly` to `private` with accessor
- Add logging
- change `fetch*` methods to be `get` functions
- Update progress bar to use something the isn't 50% (it didn't look
  like it was actually a progress bar
- Change terminal to be transient so it isn't recreated on VSCode
  restart
@esarver esarver self-assigned this Nov 19, 2024
@esarver esarver requested a review from a team as a code owner November 19, 2024 16:37
@esarver
Copy link
Member Author

esarver commented Nov 19, 2024

Merging to support reverification.

@esarver esarver merged commit 54a253a into main Nov 19, 2024
12 checks passed
@esarver esarver deleted the bug/deactivate-cleanup branch November 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@esarver esarver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esarver