Switch to GitHub Actions #1984
Merged
Switch to GitHub Actions #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Dec 2, 2020
| unit-test: | ||
| name: Unit Tests | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
The idea is to "deconstruct" the test.sh script (now deleted) into several steps in ci.yml? Is my undersetanding correct?
There was a problem hiding this comment.
Yes, the return code from each runstep is the equivalent of each test
There was a problem hiding this comment.
Thanks for the clarifications. Side comments provided. NTC regarding this one.
fgalan
reviewed
Dec 2, 2020
fgalan
reviewed
Dec 2, 2020
.github/workflows/ci.yml
Outdated
| - name: Use Java 8 | ||
| uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: 8 |
There was a problem hiding this comment.
In a similar line to https://github.com/telefonicaid/perseo-core/pull/167/files#r534058833, Java 9, 10 and 11 should be included here, although in commented form (with the same remark used in travis: FIXME: something in the current build (pom.xml?) precludes Java>8 to work).
Co-authored-by: Fermín Galán Márquez <[email protected]>
fgalan
reviewed
Dec 2, 2020
fgalan
reviewed
Dec 2, 2020
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see telefonicaid/iotagent-ul#452
Dockerlint is commented out since the Dockerfiles have not been linted yet.