Fix bug #113 #119
Fix bug #113 #119
Conversation
dcalvoalonso
commented
Mar 15, 2018
dcalvoalonso
commented
- Correct configuration API example
- Correct management of active attributes in configurations
- Trying to fix bug
- Fixing bug
| @@ -57,7 +57,7 @@ function mapConfig(device, configuration, callback) { | |||
| service: configuration.service, | |||
| subservice: configuration.subservice, | |||
| lazy: configuration.lazy, | |||
| attributes: configuration.attributes, | |||
There was a problem hiding this comment.
Related with telefonicaid/iotagent-node-lib#588...
I understand this is an internal variable not related with the keyword used in payload (i.e. "attributes"). Is my interpretation correct?
There was a problem hiding this comment.
In fact, this is the field used in the payload to describe attributes. So this was an error caused by telefonicaid/iotagent-node-lib#588
There was a problem hiding this comment.
In fact, this is the field used in the payload to describe attributes
You mean to configuration.attributes, right?
There was a problem hiding this comment.
Yes, that's right
| @@ -81,7 +81,7 @@ Lightweight M2M port. | |||
| The following request creates the configuration group for devices with type `WeatherBaloon`: | |||
There was a problem hiding this comment.
This PR is related with PR #118? In that case I understand no new entry in CNR is needed.
There was a problem hiding this comment.
PR #118 fixed the device provisioning example of https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/docs/deviceProvisioning.md, while this PR is focused on https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/docs/configurationProvisioning.md
There was a problem hiding this comment.
You're right! Someday I will not forget the CNR!
There was a problem hiding this comment.
Fixed in c9820c8
There was a problem hiding this comment.
LGTM
@dcalvoalonso should I merge? I'm asking explictly because travis fails on this PR (but I'm not sure if it something that is going to be fixed in a next PR after this one)
…2m-iotagent into bug/configuration
|
@fgalan , with the last changes I have introduced, unit tests are passed. |
