refactor: early returns

Signed-off-by: Niklas Treml <[email protected]>
telekom · Oct 29, 2024 · 6949727 · 6949727
1 parent da9e6dd
commit 6949727
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pkg/sparrow/metrics/exporter.go b/pkg/sparrow/metrics/exporter.go
@@ -122,12 +122,13 @@ func newGRPCExporter(ctx context.Context, config *Config) (sdktrace.SpanExporter
 		otlptracegrpc.WithEndpoint(config.Url),
 		otlptracegrpc.WithHeaders(headers),
 	}
-	if config.Tls.Enabled {
-		if tlsCfg != nil {
-			opts = append(opts, otlptracegrpc.WithTLSCredentials(credentials.NewTLS(tlsCfg)))
-		}
-	} else {
+
+	if !config.Tls.Enabled {
 		opts = append(opts, otlptracegrpc.WithInsecure())
+		return otlptracegrpc.New(ctx, opts...)
+	}
+	if tlsCfg != nil {
+		opts = append(opts, otlptracegrpc.WithTLSCredentials(credentials.NewTLS(tlsCfg)))
 	}
 
 	return otlptracegrpc.New(ctx, opts...)