Feat/https for everyone #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Treml <[email protected]>
Signed-off-by: Niklas Treml <[email protected]>
Signed-off-by: Niklas Treml <[email protected]>
niklastreml
added
feature
1 task
Signed-off-by: Niklas Treml <[email protected]>
|
Looks quite good to me! |
Signed-off-by: Niklas Treml <[email protected]>
Signed-off-by: Niklas Treml <[email protected]>
Signed-off-by: Niklas Treml <[email protected]>
y-eight
approved these changes
Jun 6, 2024
puffitos
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #144
This pr implements the features requested in #144
Serve API over https
Adds a tls config to allow configuring the server to use https instead of http
HTTP targets in targetmanager
Changes the targetmanager to allow non https targets by setting a new scheme value in the config
Enabled flag for targetmanager
To make our lives a bit easier when dealing with default values, I've added a flag to the targetManager config for enabling it explicitly instead of implicitly enabling it as we did before
Changes
For additional information look at the commits.
Tests done
TODO