chore/linting #24
Merged
chore/linting #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Bressi <[email protected]>
…gestions\n- RoutingTree is now a pointer to avoid mutex value copy\n- fixed some tests\n- added constants\n- simplified some loops Signed-off-by: Bruno Bressi <[email protected]>
- linted files based on suggestions - RoutingTree is now a pointer to avoid mutex value copy - fixed some tests - added constants - simplified some loops Signed-off-by: Bruno Bressi <[email protected]>
…into chore/linting
puffitos
requested review from
y-eight,
niklastreml and
lvlcn-t
as code owners
lvlcn-t
reviewed
Dec 5, 2023
|
Additionally we should talk about/take care of the many open TODO comments that are in our code base. |
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
|
PR ready after call with developers. The tests will fail (errors unhandled and unittests). Those are handled in a separate PR. |
lvlcn-t
added
refactoring
lvlcn-t
approved these changes
Dec 6, 2023
|
I have just added 2 small things: Indent for json response of checks metrics endpoint; Reduced interval of health check to 15 sec. This will be configurable in the future by #34 PR is LGTM |
y-eight
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #23
Changes
Added linting with golangci, turned off some of the most strict linters. Also implemented most of the linter's suggestions. We should discuss some of the TODOs before merging (a lot of errors were left unchecked...)
Tests done
TODO