fix: latency test race condition #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvlcn-t
requested review from
y-eight,
niklastreml and
puffitos
as code owners
|
Race cond. still present: https://github.com/caas-team/sparrow/actions/runs/7099127501/job/19323035475 |
lvlcn-t
changed the title
|
Ready for review. This PR now also partly addresses #31 but needs to be extended in another PR for the health check and other refinements. |
|
And after merging it should also close #33 since I've refactored the latency check to be more lined up with the health check |
Signed-off-by: Bruno Bressi <[email protected]>
puffitos
reviewed
Dec 6, 2023
puffitos
reviewed
Dec 6, 2023
puffitos
reviewed
Dec 6, 2023
puffitos
reviewed
Dec 6, 2023
There was a problem hiding this comment.
LGTM; @y-eight / @niklastreml I'll wait for your review as well before merging.
lvlcn-t
commented
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Address a race condition found within the
checkmethod of the Latency Check. The race condition was caused by the concurrent goroutines capturing the loop variableefrom theforloop, leading to unpredictable behavior as this variable was shared across all goroutines.Closes #27
Changes
Introduced a local copy of the loop variable in the
forloop to ensure each goroutine receives a unique, stable copy of the target URL.For additional information look at the commits.
Tests done
The unit tests succeed now.
TODO