PROTOCOL-690: Feature/aave claim aave #454

dumebi · 2021-07-21T21:39:53Z

Implemented AaveClaimAaveFacet to claim accrued aave coins

config/dapps.ts

test/helpers/story/drivers/dapp-utils/aave.utils.ts

contracts/escrow/dapps/AaveClaimAaveFacet.sol

resolved, its still showing this

updated `tokenUpdated` function to include comp added function params for comp and aave

dumebi requested review from a team, ethereumdegen, passabilities and sypeer and removed request for a team July 21, 2021 21:39

dumebi temporarily deployed to testing-keys July 21, 2021 21:39 Inactive

dumebi had a problem deploying to testing-keys July 21, 2021 21:39 Failure

dumebi requested a review from a team as a code owner July 21, 2021 22:10

dumebi temporarily deployed to testing-keys July 21, 2021 22:10 Inactive

dumebi had a problem deploying to testing-keys July 21, 2021 22:52 Failure

dumebi had a problem deploying to testing-keys July 22, 2021 07:00 Failure

dumebi temporarily deployed to testing-keys July 22, 2021 07:11 Inactive

Base automatically changed from feature/story-test/develop to develop July 26, 2021 22:52

passabilities temporarily deployed to testing-keys July 26, 2021 23:38 Inactive

passabilities requested changes Jul 26, 2021

View reviewed changes

config/dapps.ts Outdated Show resolved Hide resolved

test/helpers/story/drivers/dapp-utils/aave.utils.ts Show resolved Hide resolved

passabilities temporarily deployed to testing-keys July 27, 2021 15:35 Inactive

dumebi temporarily deployed to testing-keys July 28, 2021 20:21 Inactive

dumebi temporarily deployed to testing-keys July 28, 2021 20:45 Inactive

dumebi had a problem deploying to testing-keys July 28, 2021 20:45 Failure

dumebi requested a review from passabilities July 28, 2021 20:47

dumebi temporarily deployed to testing-keys July 29, 2021 09:16 Inactive

sypeer reviewed Aug 2, 2021

View reviewed changes

contracts/escrow/dapps/AaveClaimAaveFacet.sol Outdated Show resolved Hide resolved

dumebi had a problem deploying to testing-keys August 3, 2021 20:55 Failure

dumebi requested review from passabilities and ethereumdegen August 20, 2021 17:29

dumebi and others added 24 commits October 13, 2021 19:18

chore: aave claimAave solidity code

729c552

rebased feature/create-loan-nft-v2

880ea46

rebased with feature/create-loan-nft-v2

a87bfec

Fix chai BN array assertion

53e795b

Add Aave incentives controller for Polygon

0221d43

Update BN equal check

08ba5fc

Fix comment

2d67533

Update Compound & Aave claim

2132984

Remove file

534b1d1

fix test on polygon

2d6afee

fixed review comments

cc7557c

chore: redeem staked aave

d6e504f

remove compound address from polygon

fdbbcc5

remove documentation relative to comp on claimAave

dc67080

chore: add getNetworkName to protocol

e2194d3

claim aave and comp conditionally to user or escrow

9caed4a

patch fix accrued comp and aave

34aed04

fix: comp and aave to user

b542d5c

aave lending pool

f7f6159

fix review changes

fab0417

fix tokenUpdated parameters

d6dd7d7

fixed parameter reviews

5006700

updated `tokenUpdated` function to include comp added function params for comp and aave

remove console.log

848ee34

testing compAccrued

a79d085

dumebi force-pushed the feature/AaveClaimAave branch from 3db107b to a79d085 Compare October 13, 2021 18:42

dumebi temporarily deployed to testing-keys October 13, 2021 18:42 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PROTOCOL-690: Feature/aave claim aave #454

PROTOCOL-690: Feature/aave claim aave #454

dumebi commented Jul 21, 2021

PROTOCOL-690: Feature/aave claim aave #454

Are you sure you want to change the base?

PROTOCOL-690: Feature/aave claim aave #454

Conversation

dumebi commented Jul 21, 2021