Boni #521

sypeer · 2021-12-22T18:42:21Z

No description provided.

contracts/lending/ttoken/strategies/compound/TTokenCompoundStrategy_2.sol

deploy/markets.ts

test/helpers/set-test-env.ts

test/lending/bonusIntStrategy.ts

contracts/lending/ttoken/strategies/compound/TTokenCompoundStrategy_2.sol

deploy/markets.ts

test/helpers/set-test-env.ts

Prevents unnecessary calls to the underlying token balance

sypeer added 2 commits December 22, 2021 13:40

adding additional storage variables

b03e197

updated tToken strategy for compound with bonus int

eae9d3a

sypeer requested a review from a team as a code owner December 22, 2021 18:42

sypeer requested review from dwking2000, ethereumdegen and passabilities December 22, 2021 18:42

sypeer had a problem deploying to testing-keys December 22, 2021 18:42 Failure

passabilities requested changes Dec 22, 2021

View reviewed changes

sypeer added 5 commits December 23, 2021 12:51

using 365 days instead of BLOCKS_PER_YEAR constant

24295bc

removing unused uint

7eb578c

updating return

797401e

removing mint

60aa92b

updating strategy2 to extend from strategy1

9ec8896

sypeer had a problem deploying to testing-keys December 23, 2021 20:27 Failure

sypeer added 5 commits December 27, 2021 18:14

adding virtual modifier to strategy1 init to allow for extensibility

cd1eb3b

updating ttoken strategy deployment to pass in additional arg

d4db271

updating test setup to set an allowance on the tToken from the 'gnosis'

62a14d8

gnosisSafe address > immutable, updating the int calc, +ing constructor

eae86ef

updating market config to use compound strategy 2

f297d8b

sypeer had a problem deploying to testing-keys December 27, 2021 23:21 Failure

sypeer added 3 commits December 27, 2021 18:26

basic test setup

a65503e

updating testEnv to return hre

e3c206a

updating tToken strategy test

457daf4

sypeer had a problem deploying to testing-keys December 28, 2021 12:47 Failure

passabilities requested changes Dec 29, 2021

View reviewed changes

contracts/lending/ttoken/strategies/compound/TTokenCompoundStrategy_2.sol Outdated Show resolved Hide resolved

deploy/markets.ts Outdated Show resolved Hide resolved

test/helpers/set-test-env.ts Outdated Show resolved Hide resolved

test/lending/bonusIntStrategy.ts Show resolved Hide resolved

init funny?

01ee254

sypeer had a problem deploying to testing-keys December 30, 2021 17:20 Failure

sypeer added 3 commits January 3, 2022 12:48

updating test setup to use a fresh deployment

34285bc

updating test to use moment to advance time

7aa78ff

parsing interest calc

52411e5

sypeer temporarily deployed to testing-keys January 3, 2022 17:51 Inactive

sypeer had a problem deploying to testing-keys January 3, 2022 17:51 Failure

sypeer added 2 commits January 3, 2022 13:06

moving bonus int token approval to deploy script

26150cf

remove poly ci

6827a21

sypeer temporarily deployed to testing-keys January 3, 2022 18:07 Inactive

sypeer requested a review from passabilities January 3, 2022 21:25

passabilities requested changes Jan 3, 2022

View reviewed changes

contracts/lending/ttoken/strategies/compound/TTokenCompoundStrategy_2.sol Outdated Show resolved Hide resolved

deploy/markets.ts Outdated Show resolved Hide resolved

deploy/markets.ts Outdated Show resolved Hide resolved

test/helpers/set-test-env.ts Outdated Show resolved Hide resolved

sypeer added 3 commits January 4, 2022 13:17

adding named signer gnosisSafe

b72e604

using gnosisSafe signer in place of deployer account

bca1349

adding allowance check for gnosisSafe account

4b54ff4

sypeer temporarily deployed to testing-keys January 4, 2022 18:20 Inactive

sypeer requested a review from passabilities January 4, 2022 20:19

Move balance check inside if statement

f90f553

Prevents unnecessary calls to the underlying token balance

passabilities deployed to testing-keys January 4, 2022 20:55 Active

passabilities approved these changes Jan 4, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boni #521

Boni #521

sypeer commented Dec 22, 2021

Boni #521

Are you sure you want to change the base?

Boni #521

Conversation

sypeer commented Dec 22, 2021