Bugfix: Refactored and improved ical logic #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Alfro
commented
Apr 13, 2018
•
Alfro
commented
- Sorts the ical events list to work around the OC 4.x issue of having unordered events
- Should fix the issues regarding Ical processing: first event in event list ignored #451
- Has into account Galicaster only record the first 100 scheduled recordings #384 and should not fail with hundreds of past events
- Also fixed tests, as they were getting out-of-date.
How it works now: * Loads the ical events * Filters out passed events (not ongoing) * Sorts the remaining events (to account for them not being ordered) * If a limit is set, return the first X events given the limit 'Premature optimization is the root of all evil' -
I feel that they could be improved, these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.