-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add event trigger to handle job cleanup on table drop in vectorize schema #178
feat: Add event trigger to handle job cleanup on table drop in vectorize schema #178
Conversation
@ChuckHend @jasonmp85, please review. I would be happy to incorporate any suggestions you have : ) |
@akhilender-bongirwar another duplicate efforts with #164 PS: It's getting reviewed though I got occupied with other works recently and didn't made time to push to endline and complete PR. Anyhow will complete it now. |
@varshith257 I saw your PR was inactive for 5 days and I had a different idea for resolving the issue. |
0dfa9b8
to
2838e75
Compare
@ChuckHend, could you also review my implementation? I have a question: are all the integration tests ignored by default? If so, how are we writing and running tests to verify the changes? |
…ize schema Signed-off-by: Akhilender <[email protected]>
7b13509
to
466b34b
Compare
All of the CI was paused since this PR is from a branch outside the You will also need to add a test for this feature. Keep in mind https://github.com/tembo-io/pg_vectorize/pull/164/files was opened first, so we are reviewing that first. |
Sure, I understand : ) |
@ChuckHend, please approve workflows once. |
@ChuckHend, There are some failing tests, but I didn’t alter them, and they are not related to the changes I made. Please let me know how you would like to proceed. |
Do not worry about I'll have this reviewed within the next couple days! Thank you. |
ok. Thank you ❤️ |
Looks great! @varshith257 had a good start on this bounty early and there was clearly value added most recently in this PR from @akhilender-bongirwar. From what I've observed, there were some complementary efforts and I think it would be fair to split the bounty. I will split the bounty as soon as I can figure out how to do that. |
/split @varshith257 |
fixes #148
/claim #148