Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(cli): don't rely on temporary files #931

Merged
merged 2 commits into from
Feb 15, 2025
Merged

refac(cli): don't rely on temporary files #931

merged 2 commits into from
Feb 15, 2025

Conversation

vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Feb 14, 2025

Several refactors, the most significant being making Trunk no longer write to temporary files and instead operate only with in-memory buffers

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-931.d2qgksbj4k37j8.amplifyapp.com

@vrmiguel vrmiguel marked this pull request as ready for review February 14, 2025 22:41
Copy link
Collaborator

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, though I'd like to encourage writing thorough test coverage for new code. :-)

@vrmiguel vrmiguel merged commit bcefb5f into main Feb 15, 2025
4 checks passed
@vrmiguel vrmiguel deleted the tem-3064 branch February 15, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants