Skip to content

Commit

Permalink
Add links to StartOperationResponse_Sync (#509)
Browse files Browse the repository at this point in the history
_**READ BEFORE MERGING:** All PRs require approval by both Server AND
SDK teams before merging! This is why the number of required approvals
is "2" and not "1"--two reviewers from the same team is NOT sufficient.
If your PR is not approved by someone in BOTH teams, it may be summarily
reverted._

<!-- Describe what has changed in this PR -->
**What changed?**
Added new fields for links to Nexus `StartOperationResult_Sync`

<!-- Tell your future self why have you made these changes -->
**Why?**
So that links can be attached to sync operations

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**


<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
  • Loading branch information
pdoerner authored Jan 14, 2025
1 parent 5e65ea6 commit 2a5b395
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions openapi/openapiv2.json
Original file line number Diff line number Diff line change
Expand Up @@ -5673,6 +5673,13 @@
"properties": {
"payload": {
"$ref": "#/definitions/v1Payload"
},
"links": {
"type": "array",
"items": {
"type": "object",
"$ref": "#/definitions/apinexusv1Link"
}
}
},
"description": "An operation completed successfully."
Expand Down
1 change: 1 addition & 0 deletions temporal/api/nexus/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ message StartOperationResponse {
// An operation completed successfully.
message Sync {
temporal.api.common.v1.Payload payload = 1;
repeated Link links = 2;
}

// The operation will complete asynchronously.
Expand Down

0 comments on commit 2a5b395

Please sign in to comment.