-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-3510: Python: Added paragraph that warns about pytest.fixture(scope="session") with test server #3113
Open
edmondop
wants to merge
8
commits into
temporalio:main
Choose a base branch
from
edmondop:issue-3111
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
EDU-3510: Python: Added paragraph that warns about pytest.fixture(scope="session") with test server #3113
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f8a1cd8
Added mention about fixtures
edmondop 2143a1f
Merge branch 'main' into issue-3111
fairlydurable d6b6475
Merge branch 'main' into issue-3111
fairlydurable 92b692e
Update docs/develop/python/testing-suite.mdx
edmondop 089330f
Update docs/develop/python/testing-suite.mdx
edmondop 15f497f
Merge branch 'main' into issue-3111
edmondop 0db5697
Update docs/develop/python/testing-suite.mdx
edmondop 45851f2
Implementing feedback from PR about using explicit asynchronous fixtures
edmondop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this works without
@pytest_asyncio.fixture
andasync
andawait
. Have you tested this code? And for many, they may prefer a "session" scopedstart_local
instead of time skipping even though this only demonstrates time skipping.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, was using the auto-mode in my tests https://pytest-asyncio.readthedocs.io/en/latest/reference/configuration.html but I agree that being explicit works better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be addressed on @cretz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears the
workflow_environment()
function is now duplicated in this snippetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is to show the good and bad example, do you think one of the two fixtures should be named differently ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's a bit confusing to even have a bad example unless it's labeled more clearly and in a separate snippet. Many of our users just grab the first snippet and move on.
So in this case, we do want
start_local
to be used by users and used across tests, but if they needstart_time_skipping
you are correct that it should be per test. So maybe we should have both forms, named differently, with comments above each on why start-local is session scoped and start-time-skipping is not.