Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-3964: Update docs and samples for Nexus Go GA #3334

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

EDU-3964: Update docs and samples for Nexus Go GA #3334

wants to merge 3 commits into from

Conversation

bergundy
Copy link
Member

Please wait for a Go SDK release before merging.

prasek
prasek approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@prasek prasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, dropped a couple suggestions

docs/references/events.mdx Outdated Show resolved Hide resolved
docs/develop/go/temporal-nexus.mdx Outdated Show resolved Hide resolved
@fairlydurable fairlydurable added the waiting-on-ticket The issue has been received but has not yet been ticketed or triaged label Feb 11, 2025
@fairlydurable
Copy link
Contributor

@prasek @bergundy Please let me know when this one is okay to go

@fairlydurable fairlydurable changed the title Update docs and samples for Nexus Go GA EDU-3964: Update docs and samples for Nexus Go GA Feb 11, 2025
@fairlydurable fairlydurable added cross-team This issue or PR was submitted from within Temporal tracking-internally A JIRA ticket has been generated and the EDU number is attached to the title of this issue or PR checking-status Author, would you please let us know what the state of this PR is. Thank you. and removed waiting-on-ticket The issue has been received but has not yet been ticketed or triaged labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasek prasek prasek approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
checking-status Author, would you please let us know what the state of this PR is. Thank you. cross-team This issue or PR was submitted from within Temporal tracking-internally A JIRA ticket has been generated and the EDU number is attached to the title of this issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergundy @fairlydurable @prasek