Test Go and Java SDK client retry behavior #490
Conversation
Quinn-With-Two-Ns
force-pushed
the
issue-1742
branch
from
f24e18c
to
28f521e
Compare
There was a problem hiding this comment.
Nice. I plan on leveraging this for #455 where I'll have an HTTP endpoint on the control to fail TLS handshakes. So I may end up needing have the same proxy listen on a TLS-enabled listener too that I can tweak the TLS config on. But I don't think it'll be that hard to plug into this existing one (I hope it's just adding a new listener that's https://pkg.go.dev/crypto/tls#NewListener over the existing one).
| args := make([]string, 0, 64) | ||
| args, err := r.config.appendFlags(args) |
There was a problem hiding this comment.
| args := make([]string, 0, 64) | |
| args, err := r.config.appendFlags(args) | |
| args, err := r.config.appendFlags(nil) |
Pedantic, can be lazy if you want, heh
| private static readonly Option<string> summaryUriOption = new( | ||
| name: "--summary-uri", | ||
| description: "Where to stream the test summary JSONL (not implemented)"); |
There was a problem hiding this comment.
I hope we switch this summary thing to HTTP instead of raw TCP one day
| mu sync.Mutex | ||
| cv *sync.Cond | ||
| gc *grpc.ClientConn | ||
| gs *grpc.Server | ||
| l net.Listener | ||
| wc workflowservice.WorkflowServiceClient | ||
| ws workflowservice.WorkflowServiceServer | ||
| quitCh chan struct{} | ||
| log log.Logger | ||
| stateCond *sync.Cond |
There was a problem hiding this comment.
Don't have to do anything in this PR, but this is a bit challenging to understand w/ these field names (I understand if came from existing code)
Test Go and Java SDK client retry behavior: