Update to .NET 8 (#71)

temporalio · Jun 11, 2024 · 1b00616 · 1b00616
1 parent 49ced3d
commit 1b00616
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,7 +29,7 @@ jobs:
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 7
+          dotnet-version: 8
 
       - name: Build
         run: dotnet build

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -13,7 +13,7 @@
     <Nullable>enable</Nullable>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <RepositoryUrl>https://github.com/temporalio/samples-dotnet</RepositoryUrl>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <Version>0.1.0</Version>
   </PropertyGroup>

diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ This is the set of .NET samples for the [.NET SDK](https://github.com/temporalio
 
 Prerequisites:
 
-* .NET >= 6
+* .NET 8
 * [Local Temporal server running](https://docs.temporal.io/application-development/foundations#run-a-development-cluster)
 
 ## Samples

diff --git a/src/Encryption/Codec/EncryptionCodec.cs b/src/Encryption/Codec/EncryptionCodec.cs
@@ -71,7 +71,7 @@ private byte[] Encrypt(byte[] data)
         RandomNumberGenerator.Fill(nonceSpan);
 
         // Perform encryption
-        using (var aes = new AesGcm(key))
+        using (var aes = new AesGcm(key, TagSize))
         {
             aes.Encrypt(nonceSpan, data, bytes.AsSpan(NonceSize + TagSize), bytes.AsSpan(NonceSize, TagSize));
             return bytes;
@@ -82,7 +82,7 @@ private byte[] Decrypt(byte[] data)
     {
         var bytes = new byte[data.Length - NonceSize - TagSize];
 
-        using (var aes = new AesGcm(key))
+        using (var aes = new AesGcm(key, TagSize))
         {
             aes.Decrypt(
                 data.AsSpan(0, NonceSize), data.AsSpan(NonceSize + TagSize), data.AsSpan(NonceSize, TagSize), bytes.AsSpan());

diff --git a/src/WorkerSpecificTaskQueues/Program.cs b/src/WorkerSpecificTaskQueues/Program.cs
@@ -49,7 +49,7 @@ async Task RunWorkerAsync()
     {
         try
         {
-            tokenSource.Cancel();
+            await tokenSource.CancelAsync();
             await Task.WhenAll(tasks);
         }
         catch (Exception ex)