Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with symfony/console v7 #51

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix compatibility with symfony/console v7 #51

merged 2 commits into from
Mar 12, 2024

Conversation

sithuaung
Copy link
Contributor

@sithuaung sithuaung commented Mar 11, 2024 •
edited
Loading

What was changed

Fixed the incompatible issue.

Why?

When testing the sample code, got the error.

Checklist

  1. Closes

  2. How was this tested:

docker-compose build
docker-compose up

// and can see the error
  1. Any docs updates needed?
    No need

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@roxblnfk
Copy link
Collaborator

Hello
Please sign the CLA

@sithuaung
Copy link
Contributor Author

@roxblnfk Hi, it's done.

@roxblnfk roxblnfk changed the title Must be compatible with Symfony\Component\Console\Command\Command::execute issue fixed Fix compatibility with symfony/console v7 Mar 12, 2024
@roxblnfk roxblnfk merged commit cc56af0 into temporalio:master Mar 12, 2024
2 checks passed
@roxblnfk
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sithuaung @CLAassistant @roxblnfk