Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken TracerFactory #57

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

idealerror
Copy link
Contributor

What was changed

  • Updated open-telemetry composer versions to 1.0 as 0.0.17 no longer exists
  • Updated TracerFactory to use latest naming convention for OpenTelemetry Signals
  • Fixed TracerFactory merge() functions that don't exist

Why?

Open telemetry package versions caused docker container build to fail
TracerFactory bugs caused PHP Fatal Errors

Checklist

  1. Closes (didn't log an issue)

  2. How was this tested:
    Build docker container, run workflows

  3. Any docs updates needed?
    No

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roxblnfk roxblnfk changed the title Fixes for composer package versions and broken TracerFactory Fixes broken TracerFactory Oct 7, 2024
@roxblnfk roxblnfk merged commit 13e5ca0 into temporalio:master Oct 7, 2024
2 checks passed
@roxblnfk
Copy link
Collaborator

roxblnfk commented Oct 7, 2024

Thank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants