Skip to content

Commit

Permalink
Add dev server UI port
Browse files Browse the repository at this point in the history
  • Loading branch information
Sushisource committed Feb 5, 2025
1 parent f2d710e commit 778c7db
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/Temporalio/Bridge/OptionsExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ public static unsafe Interop.DevServerOptions ToInteropOptions(
ip = scope.ByteArray(ip),
database_filename = scope.ByteArray(options.DevServerOptions.DatabaseFilename),
ui = (byte)(options.UI ? 1 : 0),
ui_port = (ushort)options.UIPort,

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-latest)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (ubuntu-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-intel)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / build-lint-test (macos-arm)

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'

Check failure on line 396 in src/Temporalio/Bridge/OptionsExtensions.cs

View workflow job for this annotation

GitHub Actions / features-tests / test

'DevServerOptions' does not contain a definition for 'ui_port'
log_format = scope.ByteArray(options.DevServerOptions.LogFormat),
log_level = scope.ByteArray(options.DevServerOptions.LogLevel),
};
Expand Down
1 change: 1 addition & 0 deletions src/Temporalio/Bridge/include/temporal-sdk-bridge.h
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ typedef struct DevServerOptions {
*/
struct ByteArrayRef database_filename;
bool ui;
uint16_t ui_port;
struct ByteArrayRef log_format;
struct ByteArrayRef log_level;
} DevServerOptions;
Expand Down
6 changes: 6 additions & 0 deletions src/Temporalio/Bridge/src/testing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ pub struct DevServerOptions {
/// Empty means default behavior
database_filename: ByteArrayRef,
ui: bool,
ui_port: u16,
log_format: ByteArrayRef,
log_level: ByteArrayRef,
}
Expand Down Expand Up @@ -208,6 +209,11 @@ impl TryFrom<&DevServerOptions> for ephemeral_server::TemporalDevServerConfig {
.port(test_server_options.port())
.db_filename(options.database_filename.to_option_string())
.ui(options.ui)
.ui_port(if options.ui_port == 0 {
None
} else {
Some(options.ui_port)
})
.log((
options.log_format.to_string(),
options.log_level.to_string(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ public class WorkflowEnvironmentStartLocalOptions : Client.TemporalClientConnect
/// </summary>
public bool UI { get; set; }

/// <summary>
/// Gets or sets a value for the UI port to use if <see cref="UI"/> is true.
/// </summary>
public int UIPort { get; set; }

/// <summary>
/// Gets or sets search attributes registered on the dev server on start.
/// </summary>
Expand Down

0 comments on commit 778c7db

Please sign in to comment.