Nexus: Fix link not being attached to a workflow started via a Handler function #1659
+30
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,11 +252,14 @@ type WorkflowHandle[T any] interface { | |||
| ID() string | |||
| // ID is the workflow's run ID. | |||
| RunID() string | |||
| // Link to the WorkflowExecutionStarted event of the workflow represented by this handle. | |||
| Link() nexus.Link | |||
There was a problem hiding this comment.
hm why does this need to be on the interface? Are users expected to use this method?
|
I understand if we can't write an end to end test for this, but what is stopping us from unit testing this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not testing this since server 1.25.0 didn't get support for links.