Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from Temporalite to Temporal CLI dev server #339

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Move from Temporalite to Temporal CLI dev server #339

merged 1 commit into from
Jul 7, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Jul 6, 2023

What was changed

  • Use latest Temporal server for WorkflowEnvironment.start_local via CLI dev server instead of Temporalite
  • Removed the temporalite_ options from WorkflowEnvironment.start_local that were clearly documented they may be removed
  • Since we're on a new server, altered ScheduleRange step and end fields to default to what they default to on the server
  • Updated tests

Checklist

  1. Closes Temporal CLI based ephemeral server #272

@cretz cretz requested a review from a team as a code owner July 6, 2023 19:58
@cretz cretz merged commit 677f8be into temporalio:main Jul 7, 2023
11 checks passed
@cretz cretz deleted the temporal-cli branch July 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporal CLI based ephemeral server
2 participants
@cretz @Sushisource