Worker client replacement and activity client access #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
reviewed
Feb 11, 2025
| # @return [Client] Client for this worker. This is the same as {Options.client} in {options}, but surrounded by a | ||
| # mutex to be safe for client replacement in {client=}. | ||
| def client | ||
| @client_mutex.synchronize { @options.client } |
There was a problem hiding this comment.
Do we really need to acquire the mutex to read the client? Even during client replacement, that prop would be, at any moment, either the previous client or the new client, which are both valid values.
There was a problem hiding this comment.
While they both may be valid, we would prefer it be the "current" client. In Ruby (and similar languages), people expect an attribute reader to be atomic with an attribute writer of the same name, and they are for simple get/set, but this adds extra to the set side which means we need a mutex to preserve that expectation (and it's basically harmless to do so).
mjameswh
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Temporalio::Worker#clientandTemporalio::Worker#client=to support replacing client on running workerTemporalio::Activity::Context#clientto support accessing the client from the activityChecklist