Update DescribeHistoryHost to check shard ownership #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai719
approved these changes
Jan 31, 2025
|
How will this API be used in the replication stack? |
We will call this API to and it will trigger a refresh to the history client connection cache. temporal/service/frontend/admin_handler.go Line 1893 in 0682c47 |
yycptt
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update DescribeHistoryHost to check shard ownership
Why?
When providing shard id to describe history host, it needs to check shard ownership to make sure it connect to the correct history host.
How did you test it?
New unit test
Potential risks
Documentation
Is hotfix candidate?