Reduce default namespace cache refresh interval to 2s #7209
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
approved these changes
Jan 31, 2025
yux0
approved these changes
Jan 31, 2025
yycptt
reviewed
Jan 31, 2025
| @@ -42,7 +42,7 @@ import ( | |||
| const ( | |||
| WorkflowName = "temporal-sys-reclaim-namespace-resources-workflow" | |||
|
|
|||
| namespaceCacheRefreshDelay = 11 * time.Second | |||
| namespaceCacheRefreshDelay = 3 * time.Second | |||
There was a problem hiding this comment.
🤦
Let's not change it? In production we are using 2s and 11s combination and thing are fine. 2s and 3s I am not sure. Relying on this delay to make sure no new workflows are created is kinda dangerous.
cc @alexshtin WDYT?
There was a problem hiding this comment.
Sure, no strong opinion for me. Just did a quick search to try to find anywhere else we were redefining it as a constant.
There was a problem hiding this comment.
I didn't realize that we have DC for this interval. This WF should read DC, not have its own const. I will change it. Revert it to 11 for now.
alexshtin
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Reduced the default namespace cache refresh interval (dynamic config
system.namespaceCacheRefreshInterval) from 10s -> 2sWhy?
How did you test it?
Existing tests
Potential risks
Additional load on persistence from increased calls to refresh namespaces in the cache.