Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL omit redundant persistence blobs #7212

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Jan 31, 2025

What changed?

Omitting redundant persistence data blobs.

Why?

Since the original data is already there, serializing the blobs is not useful. Removing it reduces noise.

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

@stephanos stephanos marked this pull request as ready for review January 31, 2025 23:52
@stephanos stephanos requested a review from a team as a code owner January 31, 2025 23:52
@stephanos stephanos requested a review from alexshtin January 31, 2025 23:52
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a bug in serialization logic and you want manually compare blob with content :-). I believe tracing shouldn't be used for that anyway.

@stephanos stephanos merged commit cf81c5b into temporalio:main Feb 5, 2025
49 checks passed
@stephanos stephanos deleted the otel-omit-blobs branch February 5, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants