Upload code coverage #7262
Draft
Upload code coverage #7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
fix-coveralls
branch
30 times, most recently
from
de3cf47 to
a7721fc
Compare
stephanos
force-pushed
the
fix-coveralls
branch
7 times, most recently
from
1beabcb to
25ba4fe
Compare
stephanos
commented
Feb 10, 2025
| # Apply coverage analysis in each test to the given list of packages. | ||
| # The default is for each test to analyze only the package being tested. | ||
| # Packages are specified as import paths. | ||
| INTEGRATION_TEST_COVERPKG := -coverpkg="$(MODULE_ROOT)/common/persistence/..." |
There was a problem hiding this comment.
This is not needed since common/persistence tests its own package.
stephanos
force-pushed
the
fix-coveralls
branch
20 times, most recently
from
1eaa718 to
e3b0dcf
Compare
stephanos
force-pushed
the
fix-coveralls
branch
from
e3b0dcf to
20f65f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed code coverage reporting.
Why?
We haven't reported code coverage in over a year.
It stopped working when we moved away from Buildkite.
How did you test it?
See https://coveralls.io/github/temporalio/temporal?branch=fix-coveralls
Potential risks
Documentation
Is hotfix candidate?