Run integration tests again #7304
Conversation
stephanos
force-pushed
the
run-all-tests
branch
from
9380837 to
c175dc9
Compare
| @@ -1187,7 +1187,7 @@ func TestSQLiteTransactionContextCancellation(t *testing.T) { | |||
| cancel() | |||
|
|
|||
| err = tx.Commit() | |||
| assert.ErrorAs(t, err, &context.Canceled) | |||
There was a problem hiding this comment.
This yields a data race when the assertion library is trying to wrap the error.
Example: https://github.com/temporalio/temporal/actions/runs/13249022301/job/36982452711?pr=7262#step:7:27
There was a problem hiding this comment.
How this could possible work at all?
stephanos
force-pushed
the
run-all-tests
branch
from
c175dc9 to
75f221e
Compare
| @@ -309,9 +297,8 @@ func TestDLQCommand_V2(t *testing.T) { | |||
| }, | |||
| } { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
No data race if you don't run it in parallel :smart:
Makefile
Outdated
| @@ -413,13 +413,13 @@ prepare-coverage-test: $(GOTESTSUM) $(TEST_OUTPUT_ROOT) | |||
|
|
|||
| unit-test-coverage: prepare-coverage-test | |||
| @printf $(COLOR) "Run unit tests with coverage..." | |||
| go run ./cmd/tools/test-runner $(GOTESTSUM) -retries $(FAILED_TEST_RETRIES) --junitfile $(NEW_REPORT) --packages $(UNIT_TEST_DIRS) -- \ | |||
| go run ./cmd/tools/test-runner $(GOTESTSUM) -retries $(FAILED_TEST_RETRIES) --junitfile $(NEW_REPORT) --packages="$(UNIT_TEST_DIRS)" -- \ | |||
There was a problem hiding this comment.
Are you sure you need = here?
There was a problem hiding this comment.
No, but it aligns with the change I'm making in the code coverage PR (where I'm changing all of them to use = for easier parsing)
There was a problem hiding this comment.
Add them for other flags on this line then.
There was a problem hiding this comment.
I can't yet, because testrunner expects them to be like this right now.
It actually supports both 👍
stephanos
force-pushed
the
run-all-tests
branch
3 times, most recently
from
a47d46b to
d04305d
Compare
stephanos
force-pushed
the
run-all-tests
branch
from
d04305d to
cfe4635
Compare
What changed?
Run persistence integration test again.
Why?
They should be running 🙃 Somehow they were omitted when either
gotestsumorgo testparse the space-separated list of packages to test.How did you test it?
Potential risks
Documentation
Is hotfix candidate?